From 91dbaef40692a68a53aa74858f538a5699bae9ea Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jaime=20Marqui=CC=81nez=20Ferra=CC=81ndiz?=
<jaime.marquinez.ferrandiz@gmail.com>
Date: Fri, 11 Oct 2013 14:33:26 +0200
Subject: [PATCH] [nhl] Add an extractor for videocenter's categories (#1586)
It downloads the last 12 videos.
---
test/test_playlists.py | 10 +++
youtube_dl/extractor/__init__.py | 2 +-
youtube_dl/extractor/nhl.py | 105 ++++++++++++++++++++++++-------
3 files changed, 94 insertions(+), 23 deletions(-)
diff --git a/test/test_playlists.py b/test/test_playlists.py
index c33511333..de8bd298a 100644
--- a/test/test_playlists.py
+++ b/test/test_playlists.py
@@ -16,6 +16,7 @@ from youtube_dl.extractor import (
UstreamChannelIE,
SoundcloudUserIE,
LivestreamIE,
+ NHLVideocenterIE,
)
from youtube_dl.utils import *
@@ -74,5 +75,14 @@ class TestPlaylists(unittest.TestCase):
self.assertEqual(result['title'], u'TEDCity2.0 (English)')
self.assertTrue(len(result['entries']) >= 4)
+ def test_nhl_videocenter(self):
+ dl = FakeYDL()
+ ie = NHLVideocenterIE(dl)
+ result = ie.extract('http://video.canucks.nhl.com/videocenter/console?catid=999')
+ self.assertIsPlaylist(result)
+ self.assertEqual(result['id'], u'999')
+ self.assertEqual(result['title'], u'Highlights')
+ self.assertEqual(len(result['entries']), 12)
+
if __name__ == '__main__':
unittest.main()
diff --git a/youtube_dl/extractor/__init__.py b/youtube_dl/extractor/__init__.py
index a4d0c71ec..688196869 100644
--- a/youtube_dl/extractor/__init__.py
+++ b/youtube_dl/extractor/__init__.py
@@ -81,7 +81,7 @@ from .naver import NaverIE
from .nba import NBAIE
from .nbc import NBCNewsIE
from .newgrounds import NewgroundsIE
-from .nhl import NHLIE
+from .nhl import NHLIE, NHLVideocenterIE
from .ooyala import OoyalaIE
from .orf import ORFIE
from .pbs import PBSIE
diff --git a/youtube_dl/extractor/nhl.py b/youtube_dl/extractor/nhl.py
index f86d9de7e..e8d43dd13 100644
--- a/youtube_dl/extractor/nhl.py
+++ b/youtube_dl/extractor/nhl.py
@@ -11,29 +11,14 @@ from ..utils import (
)
-class NHLIE(InfoExtractor):
- IE_NAME = u'nhl.com'
- _VALID_URL = r'https?://video(?P<team>\.[^.]*)?\.nhl\.com/videocenter/console\?.*?(?<=[?&])id=(?P<id>\d+)'
+class NHLBaseInfoExtractor(InfoExtractor):
+ @staticmethod
+ def _fix_json(json_string):
+ return json_string.replace('\\\'', '\'')
- _TEST = {
- u'url': u'http://video.canucks.nhl.com/videocenter/console?catid=6?id=453614',
- u'file': u'453614.mp4',
- u'info_dict': {
- u'title': u'Quick clip: Weise 4-3 goal vs Flames',
- u'description': u'Dale Weise scores his first of the season to put the Canucks up 4-3.',
- u'duration': 18,
- u'upload_date': u'20131006',
- },
- }
-
- def _real_extract(self, url):
- mobj = re.match(self._VALID_URL, url)
- video_id = mobj.group('id')
- json_url = 'http://video.nhl.com/videocenter/servlets/playlist?ids=%s&format=json' % video_id
- info_json = self._download_webpage(json_url, video_id,
- u'Downloading info json')
- info_json = info_json.replace('\\\'', '\'')
- info = json.loads(info_json)[0]
+ def _extract_video(self, info):
+ video_id = info['id']
+ self.report_extraction(video_id)
initial_video_url = info['publishPoint']
data = compat_urllib_parse.urlencode({
@@ -57,3 +42,79 @@ class NHLIE(InfoExtractor):
'thumbnail': join(join(video_url, '/u/'), info['bigImage']),
'upload_date': unified_strdate(info['releaseDate'].split('.')[0]),
}
+
+
+class NHLIE(NHLBaseInfoExtractor):
+ IE_NAME = u'nhl.com'
+ _VALID_URL = r'https?://video(?P<team>\.[^.]*)?\.nhl\.com/videocenter/console\?.*?(?<=[?&])id=(?P<id>\d+)'
+
+ _TEST = {
+ u'url': u'http://video.canucks.nhl.com/videocenter/console?catid=6?id=453614',
+ u'file': u'453614.mp4',
+ u'info_dict': {
+ u'title': u'Quick clip: Weise 4-3 goal vs Flames',
+ u'description': u'Dale Weise scores his first of the season to put the Canucks up 4-3.',
+ u'duration': 18,
+ u'upload_date': u'20131006',
+ },
+ }
+
+ def _real_extract(self, url):
+ mobj = re.match(self._VALID_URL, url)
+ video_id = mobj.group('id')
+ json_url = 'http://video.nhl.com/videocenter/servlets/playlist?ids=%s&format=json' % video_id
+ info_json = self._download_webpage(json_url, video_id,
+ u'Downloading info json')
+ info_json = self._fix_json(info_json)
+ info = json.loads(info_json)[0]
+ return self._extract_video(info)
+
+
+class NHLVideocenterIE(NHLBaseInfoExtractor):
+ IE_NAME = u'nhl.com:videocenter'
+ IE_DESC = u'Download the first 12 videos from a videocenter category'
+ _VALID_URL = r'https?://video\.(?P<team>[^.]*)\.nhl\.com/videocenter/(console\?.*?catid=(?P<catid>[^&]+))?'
+
+ @classmethod
+ def suitable(cls, url):
+ if NHLIE.suitable(url):
+ return False
+ return super(NHLVideocenterIE, cls).suitable(url)
+
+ def _real_extract(self, url):
+ mobj = re.match(self._VALID_URL, url)
+ team = mobj.group('team')
+ webpage = self._download_webpage(url, team)
+ cat_id = self._search_regex(
+ [r'var defaultCatId = "(.+?)";',
+ r'{statusIndex:0,index:0,.*?id:(.*?),'],
+ webpage, u'category id')
+ playlist_title = self._html_search_regex(
+ r'\?catid=%s">(.*?)</a>' % cat_id,
+ webpage, u'playlist title', flags=re.DOTALL)
+
+ data = compat_urllib_parse.urlencode({
+ 'cid': cat_id,
+ # This is the default value
+ 'count': 12,
+ 'ptrs': 3,
+ 'format': 'json',
+ })
+ path = '/videocenter/servlets/browse?' + data
+ request_url = compat_urlparse.urljoin(url, path)
+ response = self._download_webpage(request_url, playlist_title)
+ response = self._fix_json(response)
+ if not response.strip():
+ self._downloader.report_warning(u'Got an empty reponse, trying '
+ u'adding the "newvideos" parameter')
+ response = self._download_webpage(request_url + '&newvideos=true',
+ playlist_title)
+ response = self._fix_json(response)
+ videos = json.loads(response)
+
+ return {
+ '_type': 'playlist',
+ 'title': playlist_title,
+ 'id': cat_id,
+ 'entries': [self._extract_video(i) for i in videos],
+ }