From 5119fbc9b7e576b95404d1ffe126c212c09c9754 Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Fri, 26 Jan 2024 12:41:39 -0500 Subject: [PATCH] Move `api/v1/admin/trends/links/preview_card_providers` to request spec (#28951) --- .../links/preview_card_providers_spec.rb} | 21 +++++++------------ 1 file changed, 8 insertions(+), 13 deletions(-) rename spec/{controllers/api/v1/admin/trends/links/preview_card_providers_controller_spec.rb => requests/api/v1/admin/trends/links/preview_card_providers_spec.rb} (60%) diff --git a/spec/controllers/api/v1/admin/trends/links/preview_card_providers_controller_spec.rb b/spec/requests/api/v1/admin/trends/links/preview_card_providers_spec.rb similarity index 60% rename from spec/controllers/api/v1/admin/trends/links/preview_card_providers_controller_spec.rb rename to spec/requests/api/v1/admin/trends/links/preview_card_providers_spec.rb index 76e215440d..384a305d4a 100644 --- a/spec/controllers/api/v1/admin/trends/links/preview_card_providers_controller_spec.rb +++ b/spec/requests/api/v1/admin/trends/links/preview_card_providers_spec.rb @@ -2,31 +2,26 @@ require 'rails_helper' -describe Api::V1::Admin::Trends::Links::PreviewCardProvidersController do - render_views - +describe 'API V1 Admin Trends Links Preview Card Providers' do let(:role) { UserRole.find_by(name: 'Admin') } let(:user) { Fabricate(:user, role: role) } let(:scopes) { 'admin:read admin:write' } let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) } + let(:headers) { { 'Authorization' => "Bearer #{token.token}" } } let(:account) { Fabricate(:account) } let(:preview_card_provider) { Fabricate(:preview_card_provider) } - before do - allow(controller).to receive(:doorkeeper_token) { token } - end - - describe 'GET #index' do + describe 'GET /api/v1/admin/trends/links/publishers' do it 'returns http success' do - get :index, params: { account_id: account.id, limit: 2 } + get '/api/v1/admin/trends/links/publishers', params: { account_id: account.id, limit: 2 }, headers: headers expect(response).to have_http_status(200) end end - describe 'POST #approve' do + describe 'POST /api/v1/admin/trends/links/publishers/:id/approve' do before do - post :approve, params: { id: preview_card_provider.id } + post "/api/v1/admin/trends/links/publishers/#{preview_card_provider.id}/approve", headers: headers end it_behaves_like 'forbidden for wrong scope', 'write:statuses' @@ -37,9 +32,9 @@ describe Api::V1::Admin::Trends::Links::PreviewCardProvidersController do end end - describe 'POST #reject' do + describe 'POST /api/v1/admin/trends/links/publishers/:id/reject' do before do - post :reject, params: { id: preview_card_provider.id } + post "/api/v1/admin/trends/links/publishers/#{preview_card_provider.id}/reject", headers: headers end it_behaves_like 'forbidden for wrong scope', 'write:statuses'