a7171af0a3
* Fix avatar and header issues by using custom geometry detector Revert a part of #6508. The file passed to dynamic styles method was not actually a file, but an instance of Paperclip::Attachment, which broke all styles by always returning {} from the method. One problem with GIF avatars was that Paperclip::GeometryDetector reported wrong dimensions for them, e.g. 120x120 GIF avatar would for some reason be detected as 120x53. By writing our own geometry parser, we can use FastImage, which also happens to be faster than ImageMagick, to detect image dimensions, which are also correct. Unfortunately, this PR does not implement skipping a `convert` entirely if the dimensions are already correct, as I found no easy way to write that behaviour into Paperclip without rewriting the Paperclip::Thumbnail class. * Only invoke convert if dimension or format needs to be changed
32 lines
994 B
Ruby
32 lines
994 B
Ruby
# frozen_string_literal: true
|
|
|
|
module AccountHeader
|
|
extend ActiveSupport::Concern
|
|
|
|
IMAGE_MIME_TYPES = ['image/jpeg', 'image/png', 'image/gif'].freeze
|
|
|
|
class_methods do
|
|
def header_styles(file)
|
|
styles = { original: { geometry: '700x335#', file_geometry_parser: FastGeometryParser } }
|
|
styles[:static] = { format: 'png', convert_options: '-coalesce', file_geometry_parser: FastGeometryParser } if file.content_type == 'image/gif'
|
|
styles
|
|
end
|
|
|
|
private :header_styles
|
|
end
|
|
|
|
included do
|
|
# Header upload
|
|
has_attached_file :header, styles: ->(f) { header_styles(f) }, convert_options: { all: '-strip' }, processors: [:lazy_thumbnail]
|
|
validates_attachment_content_type :header, content_type: IMAGE_MIME_TYPES
|
|
validates_attachment_size :header, less_than: 2.megabytes
|
|
end
|
|
|
|
def header_original_url
|
|
header.url(:original)
|
|
end
|
|
|
|
def header_static_url
|
|
header_content_type == 'image/gif' ? header.url(:static) : header_original_url
|
|
end
|
|
end
|