64ef37b89d
* Replace incorrect use of distinct with group
Some uses of ActiveRecord::QueryMethods#distinct pass field names but they
are incorrect for the current version of Rails.
ActiveRecord::QueryMethods#group provides the expected behavior and
benefits performance. See commit 6da24aad4c.
* Introduce ApplicationController#cache_collection_paginated_by_id
ApplicationController#cache_collection_paginated_by_id fuses
ApplicationController#cache_collection and Paginable.paginate_by_id.
An advantage of this method is that it prevents from modifying scope which
Paginable.paginate_by_id may provide.
ApplicationController#cache_collection always return an array and there
is no possibility of the scope modification. It is also clear for a
programmer, considering the implication of "cache".
This method can also emit more efficient queries by using
Cacheable.cache_ids before calling Paginable.paginate_by_id.
68 lines
1.9 KiB
Ruby
68 lines
1.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class ActivityPub::OutboxesController < ActivityPub::BaseController
|
|
LIMIT = 20
|
|
|
|
include SignatureVerification
|
|
include AccountOwnedConcern
|
|
|
|
before_action :require_signature!, if: :authorized_fetch_mode?
|
|
before_action :set_statuses
|
|
before_action :set_cache_headers
|
|
|
|
def show
|
|
expires_in(page_requested? ? 0 : 3.minutes, public: public_fetch_mode? && !(signed_request_account.present? && page_requested?))
|
|
render json: outbox_presenter, serializer: ActivityPub::OutboxSerializer, adapter: ActivityPub::Adapter, content_type: 'application/activity+json'
|
|
end
|
|
|
|
private
|
|
|
|
def outbox_presenter
|
|
if page_requested?
|
|
ActivityPub::CollectionPresenter.new(
|
|
id: account_outbox_url(@account, page_params),
|
|
type: :ordered,
|
|
part_of: account_outbox_url(@account),
|
|
prev: prev_page,
|
|
next: next_page,
|
|
items: @statuses
|
|
)
|
|
else
|
|
ActivityPub::CollectionPresenter.new(
|
|
id: account_outbox_url(@account),
|
|
type: :ordered,
|
|
size: @account.statuses_count,
|
|
first: account_outbox_url(@account, page: true),
|
|
last: account_outbox_url(@account, page: true, min_id: 0)
|
|
)
|
|
end
|
|
end
|
|
|
|
def next_page
|
|
account_outbox_url(@account, page: true, max_id: @statuses.last.id) if @statuses.size == LIMIT
|
|
end
|
|
|
|
def prev_page
|
|
account_outbox_url(@account, page: true, min_id: @statuses.first.id) unless @statuses.empty?
|
|
end
|
|
|
|
def set_statuses
|
|
return unless page_requested?
|
|
|
|
@statuses = @account.statuses.permitted_for(@account, signed_request_account)
|
|
@statuses = cache_collection_paginated_by_id(
|
|
@statuses,
|
|
Status,
|
|
LIMIT,
|
|
params_slice(:max_id, :min_id, :since_id)
|
|
)
|
|
end
|
|
|
|
def page_requested?
|
|
truthy_param?(:page)
|
|
end
|
|
|
|
def page_params
|
|
{ page: true, max_id: params[:max_id], min_id: params[:min_id] }.compact
|
|
end
|
|
end
|